MADS-4855 ConnectedKeyboardAcc tracks incorrectly #3830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ PR Description Validation PassedAll required sections are properly filled out:
Your PR is good for review! 🚀 This validation ensures all sections from the PR template are properly filled. |
M-i-k-e-l
approved these changes
Nov 7, 2025
M-i-k-e-l
deleted the
bugfix/v8-MADS-4855-ConnectedKeyboardAcc-tracks-incorrectly
branch
M-i-k-e-l
added a commit
that referenced
this pull request
Nov 18, 2025
* Remove old dialog * Move Incubator.Dialog to Dialog * Remove PanGestureView * Remove PanDismissibleView * Remove PanResponderView * Remove PanListenerView * Remove PanningProvider * Remove asPanViewConsumer * Remove PanningContext * Promote PanView and hooks from Incubator to standard components * Fix category * Add v8 doc * Move PanViewScreen and sort a little * Add StackAggregator doc (#3745) * Remove SharedTransition * StackAggregator - several fixes * Picker - migrate prop deprecation end (#3737) * Remove deprecated 'migrate' prop and related migration code from Picker component * refactor: PickerItem removed itemValue * docs: update Picker documentation to remove `migrate` prop and clarify value format * refactor: remove deprecated getItemLabel and getItemValue props from Picker components * refactor: simplify Picker API and enhance type safety by removing deprecated props and updating value handling * refactor: remove getItemLabel usage from Picker components and simplify label handling * docs: update Picker migration notes * refactor: remove unused getItemValue/Label --------- Co-authored-by: Miki Leib <38354019+M-i-k-e-l@users.noreply.github.com> * Upgrade to react native 0.76.9 (#3720) * Upgrade to react native 0.76.9 Some errors in native code that I did not want to commit fixes just yet docuilib has issues (hopefully will be solved in 0.77.2 * Downgrading reanimated and gesture handler * Fix snapshot * Fix TS --------- Co-authored-by: Inbal Tish <inbalti@wix.com> * RN77 new arch (#3721) * Upgrade to react native 0.76.9 Some errors in native code that I did not want to commit fixes just yet docuilib has issues (hopefully will be solved in 0.77.2 * RN77 upgrade + new arch Android runs (still need to fix native) | iOS red screen | docuilib still has errors * Remove TextInputDelKeyHandlerPackage (Android) * KeyboardAccessoryView on Android - fix crash (one bug left) Pressing on dismiss (x) only fully works the second time * Pressing on dismiss (x) only fully works the second time - a very complex fix * Remove unused code * HighlighterViewManager - fix (use new API) * Fix gesture handler changed style * Fix images (unrelated) * Fix PanViewScreen (unrelated) * Fix dragging in SortableList and SortableGridList * Update navigation * Change iOS back to Objective-C * Fix screen - border color * Revert to older reanimated and gesture-handler versions * Drawer - fix animation flickering * Remove comment * StackAggregator - several fixes - see #3210 * Drawer - fix color not being shown with multiple buttons (RectButton bug) * Fix * Downgrading reanimated and gesture handler * Fix * Fix iOS (setimmediate) * remove UIManager.setLayoutAnimationEnabledExperimental * Update RNN * Fix snapshot * Fix TS * Fix TS * Fix snapshot * Native lib reorder and fix ios (#3750) * Native lib - reorganize components in folders for convenience + bump version to 5.0.0 * pointing to index * revert naming change * fix api files * rename HighlighterOverlay web * Moving sub components to the parent * fix api file and move KeyboardUtils outside folder * Revert "fix api file and move KeyboardUtils outside folder" This reverts commit ff64327. * fix api json * fix folder name to match component name * remove specs * fix highligther view native registration * fix for SafeAreaSpacerView * fix types * fix for KeyboardTrackingView * trying to fix failed CI build * SafeAreaSpacesView - moving to react implementation using native SafeAreaManager * manager changes * fix safe area * fix SafeAreaSpacerView again * removing logs * Fix highlightViewTag type * Fix TS error * Typescript fixes \ revert * Revert --------- Co-authored-by: Miki Leib <38354019+M-i-k-e-l@users.noreply.github.com> Co-authored-by: M-i-k-e-l <michaelle@wix.com> * KeyboardAwareBase - fix error * Fix menu - "native" tag should show all (and only) native components * Update uilib-native to snapshot * Fix tests * Update uilib-native to snapshot * Fix TS error and web type * Change from codegenNativeComponent to requireNativeComponent in order to fix error after transpilation (#3768) * Change from codegenNativeComponent to requireNativeComponent * Update snapshot * Revert, move to specs and publish the typescript vesion (#3769) * Another try * Do not transpile specs * Another one * Update snapshot * SafeAreaSpacerView - fix race condition and a small refactor (#3770) * SafeAreaSpacerView - fix race condition and a small refactor * Update snapshot * Remove extra backgroundColor --------- Co-authored-by: Inbal Tish <inbalti@wix.com> Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com> * Rn77 new arch fixes 2 (#3772) * Fix Constants.statusBarHeight on iOS * SafeAreaInsetsManager - add tests and small fixes * Fix typo * Fix type * Update iOS' project * Fix reanimated interaction with RN's Modal on Android * Remove (unused) AppDelegate.swift * Update react-native-navigation * Upgrade @react-native-community/datetimepicker (known issue in iOS) * UI-LIB scrollview fix for new arch #3775 (#3775) * Revert "UI-LIB scrollview fix for new arch" This reverts commit 083661c. * UI-LIB scrollview fix for new arch #3775 (#3776) * UI-LIB scrollview fix for new arch #3775 * Update snapshot --------- Co-authored-by: M-i-k-e-l <michaelle@wix.com> * Allow overriding includeHiddenElements in (some) drivers * Change some insets to consts --------- Co-authored-by: Mark de Vocht <markd@wix.com> Co-authored-by: mark.dev <50657916+markdevocht@users.noreply.github.com> * Support includeHiddenElements in text * Update RNN to 8.1.2 and workaround for DateTimePicker's issue on iOS * UI-LIB Custom keyboard fix #3779 (#3787) * Update uilib-native to 7266 (fix AccessoryView and TrackingView) * chore(dependencies): update react-native-reanimated to 3.17.5 (#3803) * chore(dependencies): update react-native peer dependency to 0.77.0 (#3804) * chore(dependencies): update react-native-reanimated to 3.17.5 * chore(dependencies): update react-native peer dependency to 0.77.0 * yarn dedupe * Align reanimated and react-native-linear-gradient * Fix webDemo * Update to 0.77.3 and align * Prettify * AnimatedImage - use useEffect instead of onLoadStart (#3806) * AnimatedImage - use useEffect instead of onLoadStart * Fix snapshot * Replace nonexistent image * Fix test * Update snapshots * Update uilib-native to 5.0.0-snapshot.7358 * Text - fix text default alignment (#3815) * Text - fix text default alignment * Fix tests * Add docs * Add iOS to doc * Update TODO * Image - fix showing errorSource when source is undefined (iOS) (#3820) * Move uilib-native to peerDependencies (#3819) * Move logs to terminal (add --client-logs) (#3821) * AnimatedImage - use useEffect instead of onLoadStart - revert for Android (#3823) * Keyboard Accessory View not appearing at right position (#3824) * Removal of RNNAppDelegate for public repo (#3825) * Remove auto-linking from react-native-ui-lib It is not needed as uilib-native is a peerDependency * Update uilib-native snapshot * Update uilib-native docs * Dialog - add disableAnimation (#3826) * TabController - fix touch events not triggered on real Android device when scrolling with zIndex change (#3829) * TabController - fix touch events not triggered on real Android device when scrolling with zIndex change * Do not return null, use opacity\zIndex in a regular style * Improve the comment * Fix warning (#3831) * Fix warning * fix: Update Hint component snapshots by removing unused props * ts ignore --------- Co-authored-by: adids1221 <adids1221@gmail.com> * MADS-4855 ConnectedKeyboardAcc tracks incorrectly (#3830) * Infra/slider error improve data (#3836) * Slider (old) - allow equal values * Slider (incubator) - improve error * Remove Dialog from the Incubator package (#3837) * Remove Dialog from the Incubator package 2 * Fix docs and web (#3838) * Update version to 8 --------- Co-authored-by: Adi Mordo <adids1221@gmail.com> Co-authored-by: Inbal Tish <inbalti@wix.com> Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com> Co-authored-by: Mark de Vocht <markd@wix.com> Co-authored-by: mark.dev <50657916+markdevocht@users.noreply.github.com> Co-authored-by: Nitzan Yizhar <nitzany@wix.com> Co-authored-by: Nikita Shavit <70704524+NikitaShavit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://wix.atlassian.net/browse/MADS-4861
Changelog
The function of the resetting of the scrollview is no longer needed
Additional info
The scrollview doesn't need to be realigned because of the RCTLegacyViewManagerInteropComponentView being the parent of the KeyboardTrackingViewTemp in RN77